Ensure errors don't cause silent failure, make authN failure messages friendlier#89
Open
jeri-temporal wants to merge 4 commits into
Open
Ensure errors don't cause silent failure, make authN failure messages friendlier#89jeri-temporal wants to merge 4 commits into
jeri-temporal wants to merge 4 commits into
Conversation
jeri-temporal
force-pushed
the
jeri/friendly_errors
branch
from
4dd7046 to
dde51ca
Compare
Member
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0cd97f6. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
commands_test.gotocommon_test.goso it could be used for unit tests as wellFriendlyErrortype as a means of marking error messages for direct display without appending the full error chainerrors.Is/errors.Asto findFriendlyErrors that occur inside gRPC callback methodsWhy?
Running commands while not logged in (including
temporal cloud whoami) produces no output and a non-zero exit code, and other errors are similarly swallowed unless handled specifically within each command.Checklist
Closes CLDDX-141
How was this tested:
make,make test,make test-integration, verified that running commands liketemporal cloud whoamiortemporal cloud namespace listwithout being authenticated printsno login session found, please run `temporal cloud login`Any docs updates needed?
No
Note
Medium Risk
Changes global CLI failure handling and OAuth/API-key error propagation for all cloud commands, though behavior is limited to error display and wrapping with added unit tests.
Overview
Fixes silent non-zero exits when commands fail (e.g. unauthenticated
whoami) by tightening the defaultFailpath:FriendlyErrormessages go to stderr without the full chain, and if error logging is off, the full error is still printed to stderr.Auth/token failures in
GetAPIKeynow returnFriendlyError(clear login/reset guidance) and stash the original error on the gRPC context viaerrorContext/grabOriginalErrorInterceptor+GraftErrors, so handlers can still useerrors.Is/errors.Asthrough gRPC-wrapped failures.whoamiusesGetCloudClientfor consistency with other commands. Tests addCommandHarnessreuse (moved out of integration-only file), subprocess checks that stderr is user-facing (not sloglevel=), and unit coverage for friendly errors and error grafting.Reviewed by Cursor Bugbot for commit 0cd97f6. Bugbot is set up for automated code reviews on this repo. Configure here.